lkml.org 
[lkml]   [2014]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Staging: comedi: drivers: fixed a coding style issue.
Patches need to be sent inline.  Perhaps use git send-email.


On Fri, Apr 25, 2014 at 01:06:44AM -0300, Nicolas Del Piano wrote:
>
> >From 38e0d5778bd97062115e7d8a8ca40d18f3d71707 Mon Sep 17 00:00:00 2001
> From: Nicolas Del Piano <ndel314@gmail.com>
> Date: Thu, 24 Apr 2014 18:46:49 -0300
> Subject: [PATCH] Staging: comedi: drivers: fixed a missing blank line after a
> declaration coding style.
>

We don't want these headers in the patch.

> Fixed a coding style issue.
>
> Signed-off-by: Nicolas Del Piano <ndel314@gmail.com>
> ---
> drivers/staging/comedi/drivers.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c
> index cb5d214..71569bc 100644
> --- a/drivers/staging/comedi/drivers.c
> +++ b/drivers/staging/comedi/drivers.c
> @@ -439,6 +439,7 @@ static void *comedi_recognize(struct comedi_driver *driv, const char *name)
> static void comedi_report_boards(struct comedi_driver *driv)
> {
> unsigned int i;
> +
> const char *const *name_ptr;

The original code was correct. This is a bug in checkpatch.pl. The
missing line check should count any lines starting with "const" or
"static" as declarations.

regards,
dan carpenter



\
 
 \ /
  Last update: 2014-04-25 10:41    [W:1.668 / U:0.764 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site