Messages in this thread | | | Date | Fri, 25 Apr 2014 10:16:06 -0500 | From | Felipe Balbi <> | Subject | Re: [PATCHv4 5/9] extcon: max14577: Use devm_extcon_dev_allocate for extcon_dev |
| |
On Fri, Apr 25, 2014 at 09:42:20AM +0900, Chanwoo Choi wrote: > This patch use devm_extcon_dev_allocate() to simplify the memory control > of extcon device. > > Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com> > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> > Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Reviewed-by: Felipe Balbi <balbi@ti.com>
> --- > drivers/extcon/extcon-max14577.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/extcon/extcon-max14577.c b/drivers/extcon/extcon-max14577.c > index d17dd4f..d49e891 100644 > --- a/drivers/extcon/extcon-max14577.c > +++ b/drivers/extcon/extcon-max14577.c > @@ -739,14 +739,15 @@ static int max14577_muic_probe(struct platform_device *pdev) > } > > /* Initialize extcon device */ > - info->edev = devm_kzalloc(&pdev->dev, sizeof(*info->edev), GFP_KERNEL); > - if (!info->edev) { > + info->edev = devm_extcon_dev_allocate(&pdev->dev, > + max14577_extcon_cable); > + if (IS_ERR(info->edev)) { > dev_err(&pdev->dev, "failed to allocate memory for extcon\n"); > return -ENOMEM; > } > > info->edev->name = dev_name(&pdev->dev); > - info->edev->supported_cable = max14577_extcon_cable; > + > ret = devm_extcon_dev_register(&pdev->dev, info->edev); > if (ret) { > dev_err(&pdev->dev, "failed to register extcon device\n"); > -- > 1.8.0 >
-- balbi [unhandled content-type:application/pgp-signature] | |