Messages in this thread | | | From | David Laight <> | Subject | RE: [PATCH 00/13] Refactor pci_is_brdige() to simplify code | Date | Fri, 25 Apr 2014 09:42:45 +0000 |
| |
From: Yijing Wang > This patchset rename the current pci_is_bridge() to pci_has_subordinate(), > and introduce a new pci_is_bridge() which determine pci bridge by check > dev->hdr_type. The new one is more accurate. PCIe Spec define the pci > device is a bridge by the dev->hdr_type = 0x01 || 0x02.
That is a dangerous rename and is likely to cause difficult to identify bugs in any code you've missed.
David
| |