Messages in this thread | | | Date | Fri, 25 Apr 2014 07:49:08 +1000 | From | James Cameron <> | Subject | Re: [PATCH 2/2] staging: rtl8192e: Fix typo in rtl8192e |
| |
On Fri, Apr 25, 2014 at 01:48:41AM +0900, Masanari Iida wrote: > Fix spelling typo in comments within rtl8192e. > > Signed-off-by: Masanari Iida <standby24x7@gmail.com> > --- > drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c | 2 +- > drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 2 +- > drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 2 +- > drivers/staging/rtl8192e/rtl819x_TSProc.c | 2 +- > drivers/staging/rtl8192e/rtllib_rx.c | 2 +- > drivers/staging/rtl8192e/rtllib_softmac.c | 2 +- > 6 files changed, 6 insertions(+), 6 deletions(-) >
...
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c > index 498995d..59494f5 100644 > --- a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c > +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c > @@ -1213,7 +1213,7 @@ static iw_handler r8192_wx_handlers[] = { > }; > > /* > - * the following rule need to be follwing, > + * the following rule need to be following, > * Odd : get (world access), > * even : set (root access) > * */
The change is good, and a better change might be "s/rule/rules" and "s/following/followed".
On the other hand, no other driver mentions this implementation detail of IW_IS_SET in declaration of iw_priv_args, so perhaps the whole comment block should be removed.
Either way;
Reviewed-by: James Cameron <quozl@laptop.org>
p.s. nice to see you again.
-- James Cameron http://quozl.linux.org.au/
| |