lkml.org 
[lkml]   [2014]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/9] drivers/staging/speakup/: avoid world-writable sysfs files.
On Thu, Apr 24, 2014 at 01:57:49PM +0930, Rusty Russell wrote:
> Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
> > On Tue, Apr 22, 2014 at 01:03:29PM +0930, Rusty Russell wrote:
> >> In line with practice for module parameters, we're adding a build-time
> >> check that sysfs files aren't world-writable.
> >
> > Then why not just use the __ATTR_RO() macro?
>
> Hmm, I didn't know those variants existed :(
>
> But most of these are not amenable to __ATTR_RO etc, since they call
> generic helpers, eg:
>
> __ATTR(delimiters, S_IWUGO|S_IRUGO, punc_show, punc_store);
>
> I dislike the __ATTR_RO etc macros: hiding the references to the
> function from grep is Too Much Magic. (Sure, I do it in module_param,
> but that has the excuse that it allows typechecking as well).
>
> > I'd prefer some "standard" permissions for all of these sysfs files,
> > it's quite confusing otherwise, don't you agree?
>
> Agreed. So I used S_IWUSR | S_IRUGO everywhere, which is what ATTR_RW
> uses.
>
> Cheers,
> Rusty.
>
> Subject: drivers/staging/speakup/: avoid world-writable sysfs files.
>
> In line with practice for module parameters, we're adding a build-time
> check that sysfs files aren't world-writable.
>
> Cc: Christopher Brannon <chris@the-brannons.com>
> Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>


\
 
 \ /
  Last update: 2014-04-24 22:01    [W:0.040 / U:1.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site