Messages in this thread | | | Subject | Re: [PATCH] pinctrl-baytrail: fix for irq descriptor conflict on ASUS T100TA | From | Adam Williamson <> | Date | Wed, 23 Apr 2014 16:18:16 -0700 |
| |
On Wed, 2014-04-23 at 15:23 +0300, Mika Westerberg wrote: > On Wed, Apr 23, 2014 at 11:34:30AM +0300, Mika Westerberg wrote: > > On Tue, Apr 22, 2014 at 10:16:50PM -0700, Adam Williamson wrote: > > > Well, I can't actually concur. See my results in > > > https://bugzilla.kernel.org/show_bug.cgi?id=68291#c44 . > > > > > > 1. A kernel with neither patch applied (and no hid-rmi driver) results > > > in a working touchscreen. > > > 2. A kernel with only v3 of Doug's patch from > > > https://bugzilla.kernel.org/show_bug.cgi?id=67921 results in a working > > > touchscreen. > > > 3. A kernel with both v3 of Doug's patch and this IRQ descriptor > > > conflict "fix" results in a broken touchscreen. > > > > > > Seems to me there really is some kind of problem with this patch... > > > > Can you try so that you have both patches applied and then this one? I'm > > suspecting that the ACPI GPIO operation region support might do something > > unexpected in this case. > > I'm able to reproduce this problem here now and it seems not related to the > ACPI GPIO operation regions. > > This patch changes call to irq_domain_add_linear() to > irq_domain_add_simple() and somehow that changes the behaviour so that I > get non-working touchscreen: > > ... > [ 37.434998] i2c_hid i2c-ATML1000:00: failed to reset device. > [ 37.435009] i2c_hid i2c-ATML1000:00: i2c_hid_set_power > [ 37.435021] i2c_hid i2c-ATML1000:00: __i2c_hid_command: cmd=fb 00 01 08 > [ 38.439897] i2c_hid i2c-ATML1000:00: can't add hid device: -61 > [ 38.440749] i2c_hid: probe of i2c-ATML1000:00 failed with error -61 > > It never gets an interrupt when the device reset is ready. > > Jin, do you have any idea what is going on?
Well, hum - I did an encore:
4. A kernel with this IRQ descriptor conflict 'fix' but *without* Doug's patch results in a working touch screen.
So unless I made a mistake somewhere, it looks like it's really the combination of patches that causes trouble. Neither http://dougvj.net/baytrail_gpio_quirk_v3.patch nor this patch alone breaks the touch screen, but the combination of the two does. -- Adam Williamson Fedora QA Community Monkey IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net http://www.happyassassin.net
| |