Messages in this thread | | | Date | Wed, 23 Apr 2014 16:21:36 +0200 | Subject | Re: [PATCH 11/11] ext4: add cross rename support | From | Miklos Szeredi <> |
| |
On Sat, Apr 19, 2014 at 11:08 AM, Michael Kerrisk (man-pages) <mtk.manpages@gmail.com> wrote: > Hi Miklos, > >> The code changes are pushed to the git tree and the updated man page is below. > > Now that renameat2() is in 3.15, I've taken these changes. This had to be > manually does, because I'd done some major reworking on the pages since you > originally wrote your text. So, I may have injected some errors. > > I did a little light reworking of the text and added VERSIONS and > CONFORMING TO pieces. I also added a couple of FIXMEs, to note points > that will need to be updated once glibc support is (presumably) added. > (Carlos, what's the usual process for triggering that sort of thing?) > > Could you please review the diff below (now against rename(2)).
Looks okay.
One comment on the current rename.2 page:
#include <fcntl.h> /* Definition of AT_* constants */
AT_ constants are not used in renameat() hence this seems unneeded.
Not sure where the RENAME_ constants need to go once renameat2() is added to glibc, possibly to <stdio.h> since they are closely related to rename.
Thanks, Miklos
| |