Messages in this thread | | | From | Grant Likely <> | Subject | Re: [PATCH 0/3] of: dts: enable quirk for PPC32 only | Date | Wed, 23 Apr 2014 14:17:20 +0100 |
| |
On Tue, 22 Apr 2014 15:05:26 +0100, Leif Lindholm <leif.lindholm@linaro.org> wrote: > On Tue, Apr 22, 2014 at 02:08:29PM +0100, Grant Likely wrote: > > > I would prefer to see a "WARN_ON(!IS_ENABLED(CONFIG_PPC32));" added here. > > > > I completely agree. > > OK. So do we keep this around on unaffected architectures in perpetuity? > > Or can there be some cut-off date when the majority of DT-enabled > platforms can stop including this workaround which permits new incorrect > DTs to be implemented so long as they are incorrect in this particular > way?
I'd be fine with a patch that can enable the workaround selectively for specific machines. Some people will still hit breakage, but we can fix that by adding their machine to the quirk list.
g.
| |