Messages in this thread | | | Date | Tue, 22 Apr 2014 16:46:23 -0400 | From | Tejun Heo <> | Subject | Re: [PATCH 1/2 V3] workqueue: substitute POOL_FREEZING with __WQ_FREEZING |
| |
Hello,
On Tue, Apr 22, 2014 at 09:47:47AM +0800, Lai Jiangshan wrote: > Testing workqueue_freezing requires wq_pool_mutex held. > Although almost-all pwq_adjust_max_active() are called with wq_pool_mutex held, > except workqueue_set_max_active(). But I hope pwq_adjust_max_active() > don't require the heavy wq_pool_mutex.
No it doesn't require wq_pool_mutex to be held. All it requires is that the changed state is visible on the subsequent pwq_adjust_max_active() invocatino which is already trivially guaranteed.
Thanks.
-- tejun
| |