Messages in this thread | | | Date | Wed, 23 Apr 2014 12:08:55 +0900 | From | Joonsoo Kim <> | Subject | Re: [PATCH] zram: correct offset usage in zram_bio_discard |
| |
On Wed, Apr 23, 2014 at 10:32:30AM +0800, Weijie Yang wrote: > On Wed, Apr 23, 2014 at 3:55 AM, Andrew Morton > <akpm@linux-foundation.org> wrote: > > On Tue, 22 Apr 2014 11:14:02 +0800 Weijie Yang <weijie.yang@samsung.com> wrote: > > > >> we want to skip the logical block which is partially covered by > >> the discard bio, so check the remaining size and subtract it if > >> there is a need to goto the next logical block. > >> > >> This patch corrects the offset usage in zram_bio_discard. > >> > > > > What were the end-user visible effects of the bug? > > > > Please always include this information when fixing something so that > > others can work out which kernel(s) need patching. > > > > Thanks for your advise, I will resend this patch and add the end-user > visible effect information.
Thanks for fixing it.
As far as I understand, there is no end-user visible effect, because request size is alway PAGE_SIZE aligned and if n < PAGE_SIZE, no real operation happens. Am I missing?
Anyway,
Acked-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Thanks.
| |