Messages in this thread | | | From | OGAWA Hirofumi <> | Subject | Re: [PATCH v7] fs: FAT: Add support for DOS 1.x formatted volumes | Date | Mon, 21 Apr 2014 16:26:37 +0900 |
| |
Conrad Meyer <cse.cem@gmail.com> writes:
> +/* > + * A deserialized copy of the on-disk structure laid out in struct > + * fat_boot_sector. > + */ > +struct fat_bios_param_block { > + u16 fat_sector_size; > + u8 fat_sec_per_clus; > + u16 fat_reserved; > + u8 fat_fats; > + u16 fat_dir_entries; > + u16 fat_sectors; > + u16 fat_fat_length; > + u32 fat_total_sect; > + > + u8 fat16_state; > + u32 fat16_vol_id; > + > + u32 fat32_length; > + u32 fat32_root_cluster; > + u16 fat32_info_sector; > + u8 fat32_state; > + u32 fat32_vol_id; > + > +};
Looks good. But nobody use this structure except fat_fill_inode(). So, please move this into inode.c.
With above last change,
Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Thanks. -- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
| |