lkml.org 
[lkml]   [2014]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] locks: rename file-private locks to file-description locks
Am 21.04.2014 15:45, schrieb Jeff Layton:
> File-private locks have been merged into Linux for v3.15, and *now*
> people are commenting that the name and macro definitions for the new
> file-private locks suck.
>
> ...and I can't even disagree. The names and command macros do suck.
>
> We're going to have to live with these for a long time, so it's
> important that we be happy with the names before we're stuck with them.
>
> The consensus on the lists so far is that they should be rechristened as
> "file-description locks".
>
> This patch makes the following changes that I think are necessary before
> v3.15 ships:
>
> 1) rename the command macros to their new names. These end up in the uapi
> headers and so are part of the external-facing API. It turns out that
> glibc doesn't actually use the fcntl.h uapi header, but it's hard to
> be sure that something else won't. Changing it now is safest.
>
> 2) make the the /proc/locks output display these as type "FDLOCK"
>
> The rest of the renaming can wait until v3.16, since everything else
> isn't visible outside of the kernel.
>
> Cc: Michael Kerrisk <mtk.manpages@gmail.com>
> Signed-off-by: Jeff Layton <jlayton@redhat.com>

Reviewed-by: Stefan Metzmacher <metze@samba.org>


\
 
 \ /
  Last update: 2014-04-21 18:21    [W:0.078 / U:2.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site