lkml.org 
[lkml]   [2014]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: question on read_barrier_depends
On Mon, 21 Apr 2014, Oliver Neukum wrote:

> > In addition, the following code in kfifo_get() does this:
> >
> > *(typeof(__tmp->type))__val = \
> > (__is_kfifo_ptr(__tmp) ? \
> > ((typeof(__tmp->type))__kfifo->data) : \
> > (__tmp->buf) \
> > )[__kfifo->out & __tmp->kfifo.mask]; \
> > smp_wmb(); \
> > __kfifo->out++; \
> >
> > It looks like the smp_wmb() should really be smp_mb(), because it
> > separates the _read_ for val from the _write_ of kfifo->out.
>
> On the third hand, I now think wmb() is sufficient, because
> there's also a write to __val. It does depend on the read
> of buf[out & mask], but if no CPU does speculative writes
> it must be correct.

You are right; I missed that. Good point.

Alan Stern



\
 
 \ /
  Last update: 2014-04-21 16:21    [W:0.069 / U:1.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site