lkml.org 
[lkml]   [2014]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 0/2] staging: panel: fix sparse warnings.
Hi Bastien,

On Fri, Apr 18, 2014 at 06:09:18PM +0200, Bastien Armand wrote:
> This serie of two patch fix the following sparse warnings in panel.c :
> panel.c:1235:26: warning: incorrect type in argument 1 (different address spaces)
> panel.c:1235:26: expected void const volatile [noderef] <asn:1>*<noident>
> panel.c:1235:26: got char const *tmp
> panel.c:1353:20: warning: incorrect type in initializer (incompatible argument 2 (different address spaces))
> panel.c:1353:20: expected int ( *write )( ... )
> panel.c:1353:20: got int ( static [toplevel] *<noident> )( ... )
> panel.c:1591:17: warning: incorrect type in argument 1 (different address spaces)
> panel.c:1591:17: expected void const volatile [noderef] <asn:1>*<noident>
> panel.c:1591:17: got char *tmp
> panel.c:1620:20: warning: incorrect type in initializer (incompatible argument 2 (different address spaces))
> panel.c:1620:20: expected int ( *read )( ... )
> panel.c:1620:20: got int ( static [toplevel] *<noident> )( ... )
>
> Changes since v1 :
> - splitted patch in two
>
> Bastien Armand (2):
> staging: panel: fix sparse warnings in keypad_read
> staging: panel: fix sparse warnings in lcd_write

Just reviewed them both and I'm fine with these patches. You can
add my :

Acked-by: Willy Tarreau <w@1wt.eu>

Willy



\
 
 \ /
  Last update: 2014-04-20 08:41    [W:0.028 / U:0.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site