Messages in this thread | ![/](/images/icornerl.gif) | | Date | Sun, 20 Apr 2014 08:24:37 +0200 | From | Willy Tarreau <> | Subject | Re: [PATCH v2 0/2] staging: panel: fix sparse warnings. |
| |
Hi Bastien,
On Fri, Apr 18, 2014 at 06:09:18PM +0200, Bastien Armand wrote: > This serie of two patch fix the following sparse warnings in panel.c : > panel.c:1235:26: warning: incorrect type in argument 1 (different address spaces) > panel.c:1235:26: expected void const volatile [noderef] <asn:1>*<noident> > panel.c:1235:26: got char const *tmp > panel.c:1353:20: warning: incorrect type in initializer (incompatible argument 2 (different address spaces)) > panel.c:1353:20: expected int ( *write )( ... ) > panel.c:1353:20: got int ( static [toplevel] *<noident> )( ... ) > panel.c:1591:17: warning: incorrect type in argument 1 (different address spaces) > panel.c:1591:17: expected void const volatile [noderef] <asn:1>*<noident> > panel.c:1591:17: got char *tmp > panel.c:1620:20: warning: incorrect type in initializer (incompatible argument 2 (different address spaces)) > panel.c:1620:20: expected int ( *read )( ... ) > panel.c:1620:20: got int ( static [toplevel] *<noident> )( ... ) > > Changes since v1 : > - splitted patch in two > > Bastien Armand (2): > staging: panel: fix sparse warnings in keypad_read > staging: panel: fix sparse warnings in lcd_write
Just reviewed them both and I'm fine with these patches. You can add my :
Acked-by: Willy Tarreau <w@1wt.eu>
Willy
| ![\](/images/icornerr.gif) |