Messages in this thread Patch in this message | | | Subject | Re: [ANNOUNCE] 3.14-rt1 | From | Mike Galbraith <> | Date | Mon, 21 Apr 2014 05:31:18 +0200 |
| |
On Sat, 2014-04-19 at 16:46 +0200, Mike Galbraith wrote: > Hi Sebastian, > > On Fri, 2014-04-11 at 20:57 +0200, Sebastian Andrzej Siewior wrote: > > Dear RT folks! > > > > I'm pleased to announce the v3.14-rt1 patch set. > > This hunk in hotplug-light-get-online-cpus.patch looks like a bug. > > @@ -333,7 +449,7 @@ static int __ref _cpu_down(unsigned int > /* CPU didn't die: tell everyone. Can't complain. */ > smpboot_unpark_threads(cpu); > cpu_notify_nofail(CPU_DOWN_FAILED | mod, hcpu); > - goto out_release; > + goto out_cancel; > } > BUG_ON(cpu_online(cpu)); >
Another little bug. This hunk of patches/stomp-machine-raw-lock.patch should be while (atomic_read(&done.nr_todo))
@@ -647,7 +671,7 @@ int stop_machine_from_inactive_cpu(int ( ret = multi_cpu_stop(&msdata);
/* Busy wait for completion. */ - while (!completion_done(&done.completion)) + while (!atomic_read(&done.nr_todo)) cpu_relax();
mutex_unlock(&stop_cpus_mutex);
| |