Messages in this thread | | | Date | Wed, 2 Apr 2014 12:13:34 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] staging: lirc: fix NULL pointer dereference |
| |
On Wed, Apr 02, 2014 at 05:18:39PM +0900, Daeseok Youn wrote: > > coccicheck says: > drivers/staging/media/lirc/lirc_igorplugusb.c:226:15-21: > ERROR: ir is NULL but dereferenced. > > Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> > --- > drivers/staging/media/lirc/lirc_igorplugusb.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/media/lirc/lirc_igorplugusb.c b/drivers/staging/media/lirc/lirc_igorplugusb.c > index f508a13..0ef393b 100644 > --- a/drivers/staging/media/lirc/lirc_igorplugusb.c > +++ b/drivers/staging/media/lirc/lirc_igorplugusb.c > @@ -223,8 +223,8 @@ static int unregister_from_lirc(struct igorplug *ir) > int devnum; > > if (!ir) { > - dev_err(&ir->usbdev->dev, > - "%s: called with NULL device struct!\n", __func__); > + printk(DRIVER_NAME "%s: called with NULL device struct!\n", > + __func__);
It should be pr_err() or something. But actually "ir" can't be NULL so just delete the whole condition.
> return -EINVAL; > }
regards, dan carpenter
| |