lkml.org 
[lkml]   [2014]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCHv2 2/3] regmap: Add the DT binding documentation for endianness
    On Wed, Apr 02, 2014 at 06:09:08PM +0800, Xiubo Li wrote:

    > +sai2: sai@40031000 {
    > + compatible = "fsl,vf610-sai";
    > + reg = <0x40031000 0x1000>;
    > + ...
    > + val-endian = 'LE';
    > +};

    This is mostly OK as a binding (though it should be CCed to the DT list
    and maintiners as all DT bindings should) except using upper case
    doesn't really seem idiomatic for DT - lower case is more normal - and I
    don't think we can make these properties mandatory in themselves.
    Individual bindings would need to make them mandatory. It's also odd to
    have a mandatory property which may be absent!

    It'd probably be better if the binding defined what the default
    endianess was too, or just didn't say what happens in cases where
    nothing is specified, the latter seems better. Generally just not
    mentioning regmap is better for a binding definition, the binding should
    be usable by all OSs and not just Linux.
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2014-04-02 22:21    [W:4.448 / U:0.860 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site