lkml.org 
[lkml]   [2014]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] pid_namespace: pidns_get() should check task_active_pid_ns() != NULL
On 04/02, Eric W. Biederman wrote:
>
> Oleg Nesterov <oleg@redhat.com> writes:
>
> > pidns_get()->get_pid_ns() can hit ns == NULL. This task_struct can't
> > go away, but task_active_pid_ns(task) is NULL if release_task(task)
> > was already called. Alternatively we could change get_pid_ns(ns) to
> > check ns != NULL, but it seems that other callers are fine.
>
> get_pid_ns already has a ns == NULL check, so no code changes should be
> needed.

Hmm...

static inline struct pid_namespace *get_pid_ns(struct pid_namespace *ns)
{
if (ns != &init_pid_ns)
kref_get(&ns->kref);
return ns;
}

?

Oleg.



\
 
 \ /
  Last update: 2014-04-02 19:41    [W:0.080 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site