lkml.org 
[lkml]   [2014]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] fix the code style errors in sn9c102
On Sat, Apr 19, 2014 at 11:09 AM, Jinqiang Zeng <jinqiangzeng@gmail.com> wrote:
> ---
> drivers/staging/media/sn9c102/sn9c102.h | 30 +-
> drivers/staging/media/sn9c102/sn9c102_core.c | 342 ++++++++++----------
> drivers/staging/media/sn9c102/sn9c102_devtable.h | 22 +-
> drivers/staging/media/sn9c102/sn9c102_hv7131d.c | 22 +-
> drivers/staging/media/sn9c102/sn9c102_hv7131r.c | 22 +-
> drivers/staging/media/sn9c102/sn9c102_mi0343.c | 30 +-
> drivers/staging/media/sn9c102/sn9c102_mi0360.c | 30 +-
> drivers/staging/media/sn9c102/sn9c102_ov7630.c | 22 +-
> drivers/staging/media/sn9c102/sn9c102_ov7660.c | 22 +-
> drivers/staging/media/sn9c1

Hi, Jinqiang,

you just missed something.
1. a "Signed-off-by" line, if you use git, git-format-patch is a good tool.;-)
2. better add a module name in cover later, like this:
"sn9c102: fix the coding style errors"
3. maybe some changelog is good, but for this patch, leaving it out is OK.

You would better read the "Documentation/SubmittingPatches" .

Thanks,
Jianyu Zhan


\
 
 \ /
  Last update: 2014-04-19 09:01    [W:0.064 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site