lkml.org 
[lkml]   [2014]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 8/9 V2] idr: reduce the unneeded check in free_layer()
    Date
    If "idr->hint == p" is true, it also implies "idr->hint" is true(not NULL).

    Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
    Acked-by: Tejun Heo <tj@kernel.org>
    ---
    lib/idr.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/lib/idr.c b/lib/idr.c
    index 4a11c5d..e3c1da0 100644
    --- a/lib/idr.c
    +++ b/lib/idr.c
    @@ -145,7 +145,7 @@ static void idr_layer_rcu_free(struct rcu_head *head)

    static inline void free_layer(struct idr *idr, struct idr_layer *p)
    {
    - if (idr->hint && idr->hint == p)
    + if (idr->hint == p)
    RCU_INIT_POINTER(idr->hint, NULL);
    call_rcu(&p->rcu_head, idr_layer_rcu_free);
    }
    --
    1.7.4.4


    \
     
     \ /
      Last update: 2014-04-19 13:41    [W:5.554 / U:0.436 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site