Messages in this thread | | | Date | Sat, 19 Apr 2014 10:34:55 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH 0/2] memcg: mm_update_next_owner() should skip kthreads |
| |
Hi!
> > Hmm. I seem to see a bug in this function, it can be fulled by use_mm, > > but I am not sure this can explain the problem. I'll send a patch. > > Untested, please review. But it really looks "obviously wrong", and note > that unuse_mm() doesn't do mm_update_next_owner(). (just in case, do not > confuse it with unuse_mm() in mm/swapfile.c).
Having two functions, one exported, one static with same name -- that sounds quite evil, right?
mmu_context.c: * unuse_mm mmu_context.c:void unuse_mm(struct mm_struct *mm) mmu_context.c:EXPORT_SYMBOL_GPL(unuse_mm); swapfile.c:static int unuse_mm(struct mm_struct *mm, swapfile.c: retval = unuse_mm(start_mm, entry, page); swapfile.c: retval = unuse_mm(mm, entry, page); swapfile.c: * or while we dropped it in unuse_mm(). The page might even
Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |