lkml.org 
[lkml]   [2014]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf test x86: Fit memory leak in sample_ustack()
On Sun, Apr 20, 2014 at 12:19:13AM +0200, Jiri Olsa wrote:
> On Sun, Apr 20, 2014 at 12:16:41AM +0900, Masanari Iida wrote:
> > buf is not freed, when kernel failed to get stack map
> > and return.
> >
> > Signed-off-by: Masanari Iida <standby24x7@gmail.com>
>
> Acked-by: Jiri Olsa <jolsa@redhat.com>
>
> thanks,
> jirka
>
> > ---
> > tools/perf/arch/x86/tests/dwarf-unwind.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tools/perf/arch/x86/tests/dwarf-unwind.c b/tools/perf/arch/x86/tests/dwarf-unwind.c
> > index b602ad9..68f2711 100644
> > --- a/tools/perf/arch/x86/tests/dwarf-unwind.c
> > +++ b/tools/perf/arch/x86/tests/dwarf-unwind.c
> > @@ -26,6 +26,7 @@ static int sample_ustack(struct perf_sample *sample,
> > map = map_groups__find(&thread->mg, MAP__FUNCTION, (u64) sp);
> > if (!map) {
> > pr_debug("failed to get stack map\n");
> > + kfree(buf);

and changing this to free(buf) ;-)

jirka

> > return -1;
> > }
> >
> > --
> > 1.9.2.468.g3f0c02a
> >


\
 
 \ /
  Last update: 2014-04-20 00:41    [W:0.468 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site