Messages in this thread | | | Date | Thu, 17 Apr 2014 23:24:00 -0700 | Subject | Re: [PATCH v2 1/4] sysctl: clean up char buffer arguments | From | Kees Cook <> |
| |
On Thu, Apr 17, 2014 at 5:28 PM, Andi Kleen <ak@linux.intel.com> wrote: > BTW if you're worried about sysctl races you may also want to resurrect > https://lkml.org/lkml/2009/12/20/214
Yeah, this had bothered me too while reading the code. The only "good" news is that the strings are always NULL terminated and only "old" contents can ever leak. Still, it's kind of horrible that there is no locking here. :)
-Kees
-- Kees Cook Chrome OS Security
| |