lkml.org 
[lkml]   [2014]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] crypto: sha{256,512}_ssse3 - remove asmlinkage from static functions
Date
On Wednesday, April 16, 2014 at 06:19:50 PM, Jianyu Zhan wrote:
> Commit 128ea04a9885("lto: Make asmlinkage __visible") restricts
> asmlinkage to externally_visible, this causes compilation warnings:
>
> arch/x86/crypto/sha256_ssse3_glue.c:56:1:
> warning: ‘externally_visible’ attribute have effect only on public
> objects [-Wattributes]
>
> static asmlinkage void (*sha256_transform_asm)(const char *, u32 *,
> u64); ^
>
> arch/x86/crypto/sha512_ssse3_glue.c:55:1:
> warning: ‘externally_visible’ attribute have effect only on public
> objects [-Wattributes] static asmlinkage void
> (*sha512_transform_asm)(const char *, u64 *, ^
>
> Drop asmlinkage here to avoid such warnings.
>
> Also see Commit 8783dd3a37a5853689e1("irqchip: Remove asmlinkage from
> static functions")
>
> Signed-off-by: Jianyu Zhan <nasa4836@gmail.com>

Makes sense, please add my humble

Reviewed-by: Marek Vasut <marex@denx.de>

Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2014-04-17 18:01    [W:0.080 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site