Messages in this thread | | | From | "Chew, Chiau Ee" <> | Subject | RE: [PATCH] pwm_lpss: Add support for PCI devices | Date | Tue, 15 Apr 2014 08:59:31 +0000 |
| |
> On Mon, Apr 14, 2014 at 02:05:25AM +0000, Chew, Chiau Ee wrote: > > > > MODULE_DESCRIPTION("PWM driver for Intel LPSS"); > > > >MODULE_AUTHOR("Mika Westerberg > > > ><mika.westerberg@linux.intel.com>"); > > > > MODULE_LICENSE("GPL v2"); > > > > MODULE_ALIAS("platform:pwm-lpss"); > > > > > > Looks a good idea to combine pci and acpi driver together. > > > Since pci driver is added, here the alias need to be refined. > > > Others look good. > > > > > > Thanks, > > > -Aubrey > > > > Ok. I will change it to MODULE_ALIAS("pci/platform:pwm-lpss"); > > Hmm, does that really work like that? > > For PCI and ACPI you already have tables with MODULE_DEVICE_TABLE(). > > For pure platform driver (which is probably not going to be used) you nede to > have MODULE_ALIAS() if you want modprobe to load it automagically.
Ok, looks like MODULE_ALIAS() is a redundant. I will remove it.
| |