Messages in this thread | | | Subject | Re: [PATCH] ipc,shm: disable shmmax and shmall by default | From | Davidlohr Bueso <> | Date | Fri, 11 Apr 2014 13:48:07 -0700 |
| |
On Fri, 2014-04-11 at 13:27 -0700, Davidlohr Bueso wrote: > On Fri, 2014-04-11 at 20:28 +0200, Manfred Spraul wrote: > > Your patch disables checking shmmax, shmall *AND* checking for SHMMIN. > > Right, if shmmax is 0, then there's no point checking for shmmin, > otherwise we'd always end up returning EINVAL.
Actually that's complete bogus.
Now that I think of it, shmget(key, 0, flg) should still return EINVAL. That has *nothing* to do with any limits we are changing here and is simply wrong since the passed size still cannot be less than 1 (shmmin). I'll update the patch, thanks for pointing this out.
| |