lkml.org 
[lkml]   [2014]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH 30/55] scsi: Mark functions as static in megaraid/megaraid_sas_fp.c
    Date


    >-----Original Message-----
    >From: Rashika Kheria [mailto:rashika.kheria@gmail.com]
    >Sent: Saturday, March 29, 2014 11:48 PM
    >To: linux-kernel@vger.kernel.org
    >Cc: DL-MegaRAID Linux; James E.J. Bottomley; linux-scsi@vger.kernel.org;
    >josh@joshtriplett.org
    >Subject: [PATCH 30/55] scsi: Mark functions as static in
    >megaraid/megaraid_sas_fp.c
    >
    >Mark functions as static in megaraid/megaraid_sas_fp.c because they are not
    >used outside this file.
    >
    >This eliminates the following warning in megaraid/megaraid_sas_fp.c:
    >drivers/scsi/megaraid/megaraid_sas_fp.c:80:5: warning: no previous
    >prototype for ‘mega_mod64’ [-Wmissing-prototypes]
    >drivers/scsi/megaraid/megaraid_sas_fp.c:98:5: warning: no previous
    >prototype for ‘mega_div64_32’ [-Wmissing-prototypes]
    >drivers/scsi/megaraid/megaraid_sas_fp.c:206:5: warning: no previous
    >prototype for ‘MR_GetSpanBlock’ [-Wmissing-prototypes]
    >drivers/scsi/megaraid/megaraid_sas_fp.c:341:5: warning: no previous
    >prototype for ‘mr_spanset_get_span_block’ [-Wmissing-prototypes]
    >drivers/scsi/megaraid/megaraid_sas_fp.c:582:4: warning: no previous
    >prototype for ‘get_arm’ [-Wmissing-prototypes]
    >drivers/scsi/megaraid/megaraid_sas_fp.c:705:4: warning: no previous
    >prototype for ‘MR_GetPhyParams’ [-Wmissing-prototypes]
    >drivers/scsi/megaraid/megaraid_sas_fp.c:1196:4: warning: no previous
    >prototype for ‘megasas_get_best_arm’ [-Wmissing-prototypes]
    >
    >Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
    >Reviewed-by: Josh Triplett <josh@joshtriplett.org>
    >---
    > drivers/scsi/megaraid/megaraid_sas_fp.c | 26 ++++++++++++++------------
    > 1 file changed, 14 insertions(+), 12 deletions(-)
    >
    >diff --git a/drivers/scsi/megaraid/megaraid_sas_fp.c
    >b/drivers/scsi/megaraid/megaraid_sas_fp.c
    >index e24b6eb..83d5f74 100644
    >--- a/drivers/scsi/megaraid/megaraid_sas_fp.c
    >+++ b/drivers/scsi/megaraid/megaraid_sas_fp.c
    >@@ -77,7 +77,7 @@ static u8 mr_spanset_get_phy_params(struct
    >megasas_instance *instance, u32 ld, static u64 get_row_from_strip(struct
    >megasas_instance *instance, u32 ld,
    > u64 strip, struct MR_FW_RAID_MAP_ALL *map);
    >
    >-u32 mega_mod64(u64 dividend, u32 divisor)
    >+static u32 mega_mod64(u64 dividend, u32 divisor)
    > {
    > u64 d;
    > u32 remainder;
    >@@ -95,7 +95,7 @@ u32 mega_mod64(u64 dividend, u32 divisor)
    > *
    > * @return quotient
    > **/
    >-u64 mega_div64_32(uint64_t dividend, uint32_t divisor)
    >+static u64 mega_div64_32(uint64_t dividend, uint32_t divisor)
    > {
    > u32 remainder;
    > u64 d;
    >@@ -203,7 +203,7 @@ u8 MR_ValidateMapInfo(struct megasas_instance
    >*instance)
    > return 1;
    > }
    >
    >-u32 MR_GetSpanBlock(u32 ld, u64 row, u64 *span_blk,
    >+static u32 MR_GetSpanBlock(u32 ld, u64 row, u64 *span_blk,
    > struct MR_FW_RAID_MAP_ALL *map)
    > {
    > struct MR_SPAN_BLOCK_INFO *pSpanBlock = MR_LdSpanInfoGet(ld,
    >map); @@ -338,7 +338,7 @@ static int getSpanInfo(struct
    >MR_FW_RAID_MAP_ALL *map, PLD_SPAN_INFO ldSpanInfo)
    > * div_error - Devide error code.
    > */
    >
    >-u32 mr_spanset_get_span_block(struct megasas_instance *instance,
    >+static u32 mr_spanset_get_span_block(struct megasas_instance *instance,
    > u32 ld, u64 row, u64 *span_blk, struct
    >MR_FW_RAID_MAP_ALL *map) {
    > struct fusion_context *fusion = instance->ctrl_context; @@ -579,8
    >+579,8 @@ static u32 get_arm_from_strip(struct megasas_instance
    >*instance, }
    >
    > /* This Function will return Phys arm */
    >-u8 get_arm(struct megasas_instance *instance, u32 ld, u8 span, u64 stripe,
    >- struct MR_FW_RAID_MAP_ALL *map)
    >+static u8 get_arm(struct megasas_instance *instance, u32 ld, u8 span,
    >+ u64 stripe, struct MR_FW_RAID_MAP_ALL *map)
    > {
    > struct MR_LD_RAID *raid = MR_LdRaidGet(ld, map);
    > /* Need to check correct default value */ @@ -702,10 +702,11 @@
    >static u8 mr_spanset_get_phy_params(struct megasas_instance *instance,
    >u32 ld,
    > * span - Span number
    > * block - Absolute Block number in the physical disk
    > */
    >-u8 MR_GetPhyParams(struct megasas_instance *instance, u32 ld, u64
    >stripRow,
    >- u16 stripRef, struct IO_REQUEST_INFO *io_info,
    >- struct RAID_CONTEXT *pRAID_Context,
    >- struct MR_FW_RAID_MAP_ALL *map)
    >+static u8 MR_GetPhyParams(struct megasas_instance *instance, u32 ld,
    >+ u64 stripRow, u16 stripRef,
    >+ struct IO_REQUEST_INFO *io_info,
    >+ struct RAID_CONTEXT *pRAID_Context,
    >+ struct MR_FW_RAID_MAP_ALL *map)
    > {
    > struct MR_LD_RAID *raid = MR_LdRaidGet(ld, map);
    > u32 pd, arRef;
    >@@ -1193,8 +1194,9 @@ mr_update_load_balance_params(struct
    >MR_FW_RAID_MAP_ALL *map,
    > }
    > }
    >
    >-u8 megasas_get_best_arm(struct LD_LOAD_BALANCE_INFO *lbInfo, u8 arm,
    >u64 block,
    >- u32 count)
    >+static u8 megasas_get_best_arm(struct LD_LOAD_BALANCE_INFO *lbInfo,
    >u8 arm,
    >+ u64 block,
    >+ u32 count)
    > {
    > u16 pend0, pend1;
    > u64 diff0, diff1;

    Acked-by: Sumit Saxena <sumit.saxena@lsi.com>

    -Sumit
    >--
    >1.7.9.5
    >

    \
     
     \ /
      Last update: 2014-04-11 08:41    [W:5.259 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site