lkml.org 
[lkml]   [2014]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 2/5] x86: log error on secondary CPU wakeup failure at ERR level
    Date
    If system is running without debug level logging,
    it will not log error if do_boot_cpu() failed to
    wakeup AP. It may lead to silent AP bringup
    failures at boot time.
    Change message level to KERN_ERR to make error
    visible to user as it's done on other architectures.

    Signed-off-by: Igor Mammedov <imammedo@redhat.com>
    ---
    arch/x86/kernel/smpboot.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
    index 5e57a0a..853473d 100644
    --- a/arch/x86/kernel/smpboot.c
    +++ b/arch/x86/kernel/smpboot.c
    @@ -883,7 +883,7 @@ int native_cpu_up(unsigned int cpu, struct task_struct *tidle)

    err = do_boot_cpu(apicid, cpu, tidle);
    if (err) {
    - pr_debug("do_boot_cpu failed %d\n", err);
    + pr_err("do_boot_cpu failed(%d) to wakeup CPU#%u\n", err, cpu);
    return -EIO;
    }

    --
    1.7.1


    \
     
     \ /
      Last update: 2014-04-11 15:01    [W:4.328 / U:0.296 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site