lkml.org 
[lkml]   [2014]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 11/15] kernel:acct:spaces required
On Thu, Apr 10, 2014 at 07:54:06PM +0100, Paul McQuade wrote:
> ERROR: spaces required around that '>' (ctx:VxV)

Egads, man...

a) ERROR (in ALL CAPS, no less) according to whom? Sure, it's nicer to
add those spaces, but do you really think that it deserves a separate
patch, especially with such a commit message?

b) AFAICS, you've posted at least 4 such one-liners to kernel/acct.c, with
commit messages that sound like "Because The Most Holy sendpatch.pl (All Praise
sendpatch.pl) Says So". There might be some reason to split the
asm/uaccess.h -> linux/uaccess.h replacement into a separate commit, but
the rest of that? Come on...

Trivial whitespace, etc. changes like that should be clearly marked as such
and not split beyond reasonable...


\
 
 \ /
  Last update: 2014-04-10 22:01    [W:0.026 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site