Messages in this thread | | | Date | Thu, 10 Apr 2014 20:36:41 +0100 | From | Al Viro <> | Subject | Re: [PATCH 11/15] kernel:acct:spaces required |
| |
On Thu, Apr 10, 2014 at 07:54:06PM +0100, Paul McQuade wrote: > ERROR: spaces required around that '>' (ctx:VxV)
Egads, man...
a) ERROR (in ALL CAPS, no less) according to whom? Sure, it's nicer to add those spaces, but do you really think that it deserves a separate patch, especially with such a commit message?
b) AFAICS, you've posted at least 4 such one-liners to kernel/acct.c, with commit messages that sound like "Because The Most Holy sendpatch.pl (All Praise sendpatch.pl) Says So". There might be some reason to split the asm/uaccess.h -> linux/uaccess.h replacement into a separate commit, but the rest of that? Come on...
Trivial whitespace, etc. changes like that should be clearly marked as such and not split beyond reasonable...
| |