Messages in this thread | | | Date | Thu, 10 Apr 2014 20:05:32 +0200 | Subject | Re: [PATCH] staging: r8723au: Add missing initialization of change_inx in sort algorithm | From | Geert Uytterhoeven <> |
| |
Hi Larry,
On Thu, Apr 10, 2014 at 8:01 PM, Larry Finger <Larry.Finger@lwfinger.net> wrote: > On 04/10/2014 12:46 PM, Geert Uytterhoeven wrote: >> >> drivers/staging/rtl8723au/core/rtw_wlan_util.c: In function >> ‘WMMOnAssocRsp23a’: >> drivers/staging/rtl8723au/core/rtw_wlan_util.c:684: warning: ‘change_inx’ >> may be used uninitialized in this function >> >> Depending on the uninitialized data on the stack, the array may not be >> sorted correctly. >> >> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> >> --- > > Acked-by: Larry Finger <Larry.Finger@lwfinger.net> > > Geert, > > Thanks for this. I wonder why my gcc on x86_64 did not flag this problem.
Because it's too new?
Several warnings were disabled in more recent versions of gcc (still using 4.1.2 for m68k here ;-) due to too many false positives.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |