Messages in this thread | | | From | "Romer, Benjamin M" <> | Date | Thu, 10 Apr 2014 09:56:42 -0500 | Subject | Re: [PATCH] unisys: staging: Check for s-Par firmware before initializing s-Par modules |
| |
On Wed, 2014-04-09 at 12:25 -0700, Greg Kroah-Hartman wrote: > Patches need to do only one thing, so can you please split this up in to > multiple patches, each one only doing one thing.
Sorry about that! I'll send another patch that fixes all of the copyright statements at once then. :)
> You forgot to add a "Reported-by:" line here, and possibly a > "Tested-by:" if someone tested it and reported that it solved the > problem. Proper attribution is very important.
Will do! Thanks for all the feedback. I'll rework my patch. :)
-- Ben
| |