Messages in this thread | | | Date | Tue, 1 Apr 2014 08:34:44 +0200 | From | Anders Darander <> | Subject | Re: [PATCH v2] Staging: ft1000-usb: fixed a few code style issues |
| |
* Greg KH <gregkh@linuxfoundation.org> [140401 00:53]:
> On Mon, Mar 31, 2014 at 08:26:28AM +0200, Anders Darander wrote: > > Fixed a few code style issues, particularly:
> > Add do {} while (0) wrapper around seq_* macros. > > Change printk(KERN_WARN...) to netdev_warn(...).
> That's 2 different things, please split this up into 2 different > patches.
Split up patches on their way.
> Remember, one patch does one thing.
Sure.
In this case I deemed them to be small and though not the same, but still mosly coding style issues. Though, I can certainly see that the printk to netdev_warn actually adds more than just a coding style clean-up.
Cheers, Anders
| |