lkml.org 
[lkml]   [2014]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] Staging: ft1000-usb: fixed a few code style issues
* Greg KH <gregkh@linuxfoundation.org> [140401 00:53]:

> On Mon, Mar 31, 2014 at 08:26:28AM +0200, Anders Darander wrote:
> > Fixed a few code style issues, particularly:

> > Add do {} while (0) wrapper around seq_* macros.
> > Change printk(KERN_WARN...) to netdev_warn(...).

> That's 2 different things, please split this up into 2 different
> patches.

Split up patches on their way.

> Remember, one patch does one thing.

Sure.

In this case I deemed them to be small and though not the same, but
still mosly coding style issues. Though, I can certainly see that the
printk to netdev_warn actually adds more than just a coding style
clean-up.

Cheers,
Anders



\
 
 \ /
  Last update: 2014-04-01 10:32    [W:0.139 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site