lkml.org 
[lkml]   [2014]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/2] arm: socfpga: Add support for Altera SoC SDRAM controller
From
Date
On Tue, 2014-04-01 at 07:33 +0200, Steffen Trumtrar wrote:
> On Mon, Mar 31, 2014 at 05:07:07PM -0500, tthayer@altera.com wrote:
> > From: Thor Thayer <tthayer@altera.com>
> >
<snip>
> >
>
> Can't we get rid of all these global pointers instead of adding to them?

Yes. I will remove this file from the patch. Thanks.

>
> > @@ -150,6 +151,15 @@ void __init socfpga_sysmgr_init(void)
> >
> > np = of_find_compatible_node(NULL, NULL, "altr,clk-mgr");
> > clk_mgr_base_addr = of_iomap(np, 0);
> > +
> > + np = of_find_compatible_node(NULL, NULL, "altr,sdr-ctl");
> > + if (!np) {
> > + pr_err("SOCFPGA: Unable to find sdr-ctl\n");
> > + return;
> > + }
> > +
> > + sdr_ctl_base_addr = of_iomap(np, 0);
> > + WARN_ON(!sdr_ctl_base_addr);
> > }
> >
> > static void __init socfpga_init_irq(void)
> > --
> > 1.7.9.5
> >
>



\
 
 \ /
  Last update: 2014-04-01 22:41    [W:1.717 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site