lkml.org 
[lkml]   [2014]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2] mac80211: LLVMLinux: Remove VLAIS usage from mac80211
    On 03/08/14 15:00, Sergei Antonov wrote:
    > On 8 March 2014 23:01, PaX Team <pageexec@freemail.hu> wrote:
    >> On 8 Mar 2014 at 21:29, Sergei Antonov wrote:
    >>
    >>>> - memset(&aead_req, 0, sizeof(aead_req));
    >>>> + char aead_req_data[sizeof(struct aead_request) +
    >>>> + crypto_aead_reqsize(tfm) +
    >>>> + CRYPTO_MINALIGN] CRYPTO_MINALIGN_ATTR;
    >> ^^^^^^^^^^^^^^^^^^^^
    >> wouldn't the underlined attribute ensure the required alignment?
    > Yes. Sorry, I overlooked it.
    >
    > I would remove unneeded CRYPTO_MINALIGN and get the alignment from the
    > target structure:
    > char aead_req_data[sizeof(struct aead_request) +
    > crypto_aead_reqsize(tfm)]
    > __attribute__((__aligned__(__alignof__(struct aead_request))));
    Even better. Will resubmit.

    Behan

    --
    Behan Webster
    behanw@converseincode.com



    \
     
     \ /
      Last update: 2014-03-09 03:41    [W:2.937 / U:0.816 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site