Messages in this thread | | | Date | Sat, 08 Mar 2014 17:24:09 -0700 | From | Jens Axboe <> | Subject | Re: [PATCH] block: fix q->flush_rq NULL pointer crash on dm-mpath flush |
| |
On 2014-03-08 15:09, Mike Snitzer wrote: > On Sat, Mar 08 2014 at 4:33pm -0500, > Hannes Reinecke <hare@suse.de> wrote: > >> On 03/08/2014 07:13 PM, Mike Snitzer wrote: >>> >>> I'm calm.. was just a bit frustrated. But this isn't a big deal. >>> I'll make an effort to reach out to relevant people sooner when >>> similar stuff is reported against recently upstreamed code. Would be >>> cool if you did the same. I can relate to needing to have the distro >>> vendor hat on (first needing to determine/answer "is this issue >>> specific to our hacked distro kernel?", etc). >>> >> The patch I made wasn't in the context of 'recently upstreamed >> code', it was due to a backport Jan Kara did for our next distro >> kernels (3.12-based). > > "3.12-based" means nothing given all the backporting for SLES, much like > "3.10-based" means nothing in the context of RHEL7. > > The only way this fix is applicable is in the context of "recently > upstreamed code", commit 1874198 ("blk-mq: rework flush sequencing > logic") went upstream for v3.14-rc3. > > Jens, please feel free to queue this tested fix for 3.14-rc:
Thanks Mike, queued up. Also queued up the list addition reversal change.
-- Jens Axboe
| |