Messages in this thread | | | Date | Sat, 8 Mar 2014 07:52:40 -0800 | From | Christoph Hellwig <> | Subject | Re: [PATCH 1/1] block: rework flush sequencing for blk-mq |
| |
On Fri, Mar 07, 2014 at 03:45:09PM -0500, Jeff Moyer wrote: > Hi, Christoph, > > Did you mean to switch from list_add to list_add_tail? That seems like > a change that warrants mention.
No, that wasn't intentional and should be fixed. Btw, there was another issue with that commit, in that dm-multipath also needs to allocate ->flush_rq. I saw a patch from Hannes fixing it in the SuSE tree, and would really love to see him submit that for mainline as well.
Unfortunately SuSE seems to have lots of block and dm fixes and even features that they don't submit upstream.
| |