Messages in this thread | | | From | Grant Likely <> | Subject | Re: [PATCH v6 3/8] of: Warn if of_graph_get_next_endpoint is called with the root node | Date | Fri, 07 Mar 2014 18:28:03 +0000 |
| |
On Wed, 5 Mar 2014 10:20:37 +0100, Philipp Zabel <p.zabel@pengutronix.de> wrote: > If of_graph_get_next_endpoint is given a parentless node instead of an > endpoint node, it is clearly a bug. > > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Acked-by: Grant Likely <grant.likely@linaro.org>
> --- > Changes since v5: > - Added parentless previous endpoint's full name to warning > --- > drivers/of/base.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/of/base.c b/drivers/of/base.c > index b2f223f..b5e690b 100644 > --- a/drivers/of/base.c > +++ b/drivers/of/base.c > @@ -2028,8 +2028,8 @@ struct device_node *of_graph_get_next_endpoint(const struct device_node *parent, > of_node_put(node); > } else { > port = of_get_parent(prev); > - if (!port) > - /* Hm, has someone given us the root node ?... */ > + if (WARN_ONCE(!port, "%s(): endpoint %s has no parent node\n", > + __func__, prev->full_name)) > return NULL; > > /* Avoid dropping prev node refcount to 0. */ > -- > 1.9.0.rc3 >
| |