lkml.org 
[lkml]   [2014]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/5] r8a7790.dtsi: add vin[0-3] nodes
Hello.

On 03/07/2014 04:01 PM, Ben Dooks wrote:

> Add nodes for the four video input channels on the R8A7790.

> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>

This patch should have been preceded by the VIN driver patch and bindings
description, don't you think?

> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
> index a1e7c39..4c3eafb 100644
> --- a/arch/arm/boot/dts/r8a7790.dtsi
> +++ b/arch/arm/boot/dts/r8a7790.dtsi
> @@ -395,6 +395,38 @@
> status = "disabled";
> };
>
> + vin0: vin@0xe6ef0000 {

ePAPR standard [1] tells us that:

The name of a node should be somewhat generic, reflecting the function of the
device and not its precise programming model.

So, I would suggest something like "video". And remove "0x" from the
address part of the node name please.

WBR, Sergei



\
 
 \ /
  Last update: 2014-03-07 17:21    [W:0.243 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site