Messages in this thread Patch in this message | | | Date | Fri, 07 Mar 2014 10:09:23 -0500 | From | Steven Rostedt <> | Subject | [for-next][PATCH 03/20] tracepoint: Do not waste memory on mods with no tracepoints |
| |
From: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org>
No reason to allocate tp_module structures for modules that have no tracepoints. This just wastes memory.
Fixes: b75ef8b44b1c "Tracepoint: Dissociate from module mutex" Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Signed-off-by: Steven Rostedt <rostedt@goodmis.org> --- kernel/tracepoint.c | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/kernel/tracepoint.c b/kernel/tracepoint.c index 29f2654..0d4ef26 100644 --- a/kernel/tracepoint.c +++ b/kernel/tracepoint.c @@ -636,6 +636,9 @@ static int tracepoint_module_coming(struct module *mod) struct tp_module *tp_mod, *iter; int ret = 0; + if (!mod->num_tracepoints) + return 0; + /* * We skip modules that taint the kernel, especially those with different * module headers (for forced load), to make sure we don't cause a crash. @@ -679,6 +682,9 @@ static int tracepoint_module_going(struct module *mod) { struct tp_module *pos; + if (!mod->num_tracepoints) + return 0; + mutex_lock(&tracepoints_mutex); tracepoint_update_probe_range(mod->tracepoints_ptrs, mod->tracepoints_ptrs + mod->num_tracepoints); -- 1.8.5.3
| |