Messages in this thread | | | Date | Thu, 06 Mar 2014 10:59:44 -0700 | From | Stephen Warren <> | Subject | Re: [PATCH v2 3/3] ARM: tegra: dalmore: add thermal zones for nct1008 |
| |
On 03/04/2014 04:31 AM, Wei Ni wrote: > Add dt node to describe the thermal zone for the nct1008.
> diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
> + thermal-zones { > + nct1008-local { > + polling-delay-passive = <2000>; /* milliseconds */ > + polling-delay = <0>; /* milliseconds */
A delay of 0 implies that software continually polls this zone, thus consuming an entire CPU. Is this really what you want?
> + > + thermal-sensors = <&nct1008 0>; > + };
This zone (and the other) is missing the required (per the binding documentation) trips and cooling-maps sub-nodes.
I've also sent a query in response to the thermal-zones binding so see whether or not it can be fixed so that software doesn't bind against the node name, but rather against a compatible property like almost everything else. Let's see what the response is there before reposting this patch.
| |