lkml.org 
[lkml]   [2014]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 Resend 2/3] regulator: Add support for S2MPA01 regulator
From
Hi Krzysztof,

On 6 March 2014 16:10, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> On Thu, 2014-03-06 at 15:30 +0530, Sachin Kamat wrote:
>> Add support for S2MPA01 voltage and current regulator.

>> +
>> +struct s2mpa01_info {
>> + struct regulator_dev *rdev[S2MPA01_REGULATOR_MAX];
>
> Hi,
>
> It seems that s2mpa01_info->rdev is not used anywhere, except as return
> value of devm_regulator_register. I think you can remove it completely.

Yes. I will send a follow up patch for this.

>
> Beside that, can this driver be merged into existing s2mps11 regulator
> driver?

Haven't analyzed this yet. Will look into the possibility of consolidation
later.

Thank you for your feedback.

--
With warm regards,
Sachin


\
 
 \ /
  Last update: 2014-03-09 15:21    [W:0.138 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site