Messages in this thread | | | Date | Thu, 6 Mar 2014 16:52:21 +0530 | Subject | Re: [PATCH v3 Resend 2/3] regulator: Add support for S2MPA01 regulator | From | Sachin Kamat <> |
| |
Hi Krzysztof,
On 6 March 2014 16:10, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote: > On Thu, 2014-03-06 at 15:30 +0530, Sachin Kamat wrote: >> Add support for S2MPA01 voltage and current regulator.
>> + >> +struct s2mpa01_info { >> + struct regulator_dev *rdev[S2MPA01_REGULATOR_MAX]; > > Hi, > > It seems that s2mpa01_info->rdev is not used anywhere, except as return > value of devm_regulator_register. I think you can remove it completely.
Yes. I will send a follow up patch for this.
> > Beside that, can this driver be merged into existing s2mps11 regulator > driver?
Haven't analyzed this yet. Will look into the possibility of consolidation later.
Thank you for your feedback.
-- With warm regards, Sachin
| |