Messages in this thread | | | Date | Thu, 6 Mar 2014 19:26:49 -0800 | From | Bjorn Andersson <> | Subject | Re: [PATCH] pinctrl: msm: drop wake_irqs bitmap |
| |
On Wed 05 Mar 11:33 PST 2014, Josh Cartwright wrote:
> Currently, the wake_irqs bitmap is used to track whether there are any > gpio's which are configured as wake irqs, and uses this to determine > whether or not to call enable_irq_wake()/disable_irq_wake() on the > summary interrupt. > > However, the genirq core already handles this case, by maintaining a > 'wake_count' per irq_desc, and only calling into the controlling > irq_chip when wake_count transitions 0 <-> 1. > > Drop this bitmap, and unconditionally call irq_set_irq_wake() on the > summary interrupt.
I wasn't aware of that, change looks good!
Acked-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
| |