Messages in this thread | | | Date | Thu, 6 Mar 2014 15:35:30 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] checkpatch: net and drivers/net: Warn on missing blank line after variable declaration |
| |
On Thu, 06 Mar 2014 15:28:40 -0800 Joe Perches <joe@perches.com> wrote:
> Networking prefers this style, so warn when it's not used. > > Networking uses: > > void foo(int bar) > { > int baz; > > code... > } > > not > > void foo(int bar) > { > int baz; > code... > } > > There are a limited number of false positives when using > macros to declare variables like: > > WARNING: networking uses a blank line after declarations > #330: FILE: net/ipv4/inet_hashtables.c:330: > + int dif = sk->sk_bound_dev_if; > + INET_ADDR_COOKIE(acookie, saddr, daddr)
um wait wut wot.
*All* kernel code uses blank line between end-of-locals and start-of-code. Or if it doesn't it should, thwap.
Why are we special-casing net/?
| |