Messages in this thread | | | Date | Thu, 06 Mar 2014 16:07:55 -0500 (EST) | Subject | Re: [PATCH] phy: fix compiler array bounds warning on settings[] | From | David Miller <> |
| |
From: Bjorn Helgaas <bhelgaas@google.com> Date: Tue, 04 Mar 2014 17:35:44 -0700
> With -Werror=array-bounds, gcc v4.7.x warns that in phy_find_valid(), the > settings[] "array subscript is above array bounds", I think because idx is > a signed integer and if the caller supplied idx < 0, we pass the guard but > still reference out of bounds. > > Fix this by making idx unsigned here and elsewhere. > > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Applied, thanks.
| |