lkml.org 
[lkml]   [2014]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] usbip:vhci_sysfs.c: check return value of sscanf
On 03/06/2014 11:36 AM, John de la Garza wrote:
> Added code to check return value of sscanf.
>
> Signed-off-by: John de la Garza <john@jjdev.com>
> ---
> drivers/staging/usbip/vhci_sysfs.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/usbip/vhci_sysfs.c b/drivers/staging/usbip/vhci_sysfs.c
> index 03e6edf..82dd49f 100644
> --- a/drivers/staging/usbip/vhci_sysfs.c
> +++ b/drivers/staging/usbip/vhci_sysfs.c
> @@ -114,7 +114,8 @@ static ssize_t store_detach(struct device *dev, struct device_attribute *attr,
> int err;
> __u32 rhport = 0;
>
> - sscanf(buf, "%u", &rhport);
> + if (sscanf(buf, "%u", &rhport) != 1)
> + return -EINVAL;
>
> /* check rhport */
> if (rhport >= VHCI_NPORTS) {
> @@ -182,7 +183,8 @@ static ssize_t store_attach(struct device *dev, struct device_attribute *attr,
> * @devid: unique device identifier in a remote host
> * @speed: usb device speed in a remote host
> */
> - sscanf(buf, "%u %u %u %u", &rhport, &sockfd, &devid, &speed);
> + if (sscanf(buf, "%u %u %u %u", &rhport, &sockfd, &devid, &speed) != 1)
> + return -EINVAL;
>
> usbip_dbg_vhci_sysfs("rhport(%u) sockfd(%u) devid(%u) speed(%u)\n",
> rhport, sockfd, devid, speed);
>

Looks good to me.

Reviewed-by: Shuah Khan <shuah.kh@samsung.com>

-- Shuah

--
Shuah Khan
Senior Linux Kernel Developer - Open Source Group
Samsung Research America(Silicon Valley)
shuah.kh@samsung.com | (970) 672-0658


\
 
 \ /
  Last update: 2014-03-06 22:01    [W:0.025 / U:1.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site