Messages in this thread | | | Date | Thu, 06 Mar 2014 18:35:20 +0200 | From | "Ivan T. Ivanov" <> | Subject | Re: [PATCH v5 10/14] usb: phy: msm: Use reset framework for LINK and PHY resets |
| |
On 03/05/14 14:34, Sergei Shtylyov wrote: > Hello. >
>> --- a/drivers/usb/phy/phy-msm-usb.c >> +++ b/drivers/usb/phy/phy-msm-usb.c > [...] >> @@ -235,12 +236,16 @@ static void ulpi_init(struct msm_otg *motg) >> >> static int msm_otg_link_clk_reset(struct msm_otg *motg, bool assert) >> { >> - int ret = 0; >> + int ret; >> >> - if (!motg->pdata->link_clk_reset) >> - return ret; >> + if (motg->pdata->link_clk_reset) >> + ret = motg->pdata->link_clk_reset(motg->clk, assert); >> + else >> + if (assert) > > Kernel style assumes: > > else if (assert)
Thanks. will fix it.
Regards, Ivan
> >> + ret = reset_control_assert(motg->link_rst); >> + else >> + ret = reset_control_deassert(motg->link_rst); >> > [...] > > WBR, Sergei > >
| |