lkml.org 
[lkml]   [2014]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: Patch[Kernel 3.13.5]
On Thu, Mar 06, 2014 at 04:00:04AM +0000, Nick Krause wrote:
> Here is my first patch, adding a break point to fix bug 60845, case fallout through on switch
> in arch/mips/pci/msi-octeon.c.
>
> --- //home/nick/linux-3.13.5/arch/mips/pci/msi-octeon.c.orig    2014-03-05 22:48:19.084372515 -0500
> +++ //home/nick/linux-3.13.5/arch/mips/pci/msi-octeon.c    2014-03-05 22:48:48.388372344 -0500
> @@ -150,6 +150,7 @@ msi_irq_allocated:
>          msg.address_lo =
>              ((128ul << 20) + CVMX_PCI_MSI_RCV) & 0xffffffff;
>          msg.address_hi = ((128ul << 20) + CVMX_PCI_MSI_RCV)>> 32;
> +        break;
>      case OCTEON_DMA_BAR_TYPE_BIG:
>          /* When using big bar, Bar 0 is based at 0 */
>          msg.address_lo = (0 + CVMX_PCI_MSI_RCV) & 0xffffffff;
> Got one error no maintainer otherwise not issues with coding style.

Looks like a real bug you've found, as e8635b484f644 still has the
"break" in there.

However, if you want to learn how to prepare patches properly, take a
look at Documentation/SubmittingPatches.

There it also says how to find out who exactly to send this patch to:

$ ./scripts/get_maintainer.pl -f arch/mips/pci/msi-octeon.c
Ralf Baechle <ralf@linux-mips.org> (supporter:MIPS)
linux-mips@linux-mips.org (open list:MIPS)

I've CCed them.

--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2014-03-06 12:22    [W:0.145 / U:0.664 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site