Messages in this thread | | | Date | Thu, 6 Mar 2014 18:33:50 +0800 | From | Wang YanQing <> | Subject | Re: [PATCH] video: fbdev: uvesafb: use CONFIG_X86_PAE surround _PAGE_NX check code |
| |
On Thu, Mar 06, 2014 at 11:56:37AM +0200, Tomi Valkeinen wrote: > I don't like this, I think this makes the code more messy, just to avoid > that warning. > > And it might even be buggy. For your patch to work correctly, you need > to know the internals of _PAGE_NX, i.e. that when CONFIG_X86_PAE is not > defined, _PAGE_NX is 0. But the driver should not depend on things like > that. If _PAGE_NX is changed later, the driver will not work correctly. >
Very right! Thanks.
| |