lkml.org 
[lkml]   [2014]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.11 116/131] PM / hibernate: Fix restore hang in freeze_processes()
    Date
    3.11.10.6 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Sebastian Capella <sebastian.capella@linaro.org>

    commit f8d5b9e9e5372f0deb7bc1ab1088a9b60b0a793d upstream.

    During restore, pm_notifier chain are called with
    PM_RESTORE_PREPARE. The firmware_class driver handler
    fw_pm_notify does not have a handler for this. As a result,
    it keeps a reader on the kmod.c umhelper_sem. During
    freeze_processes, the call to __usermodehelper_disable tries to
    take a write lock on this semaphore and hangs waiting.

    Signed-off-by: Sebastian Capella <sebastian.capella@linaro.org>
    Acked-by: Ming Lei <ming.lei@canonical.com>
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    drivers/base/firmware_class.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
    index c8dac74..8933926 100644
    --- a/drivers/base/firmware_class.c
    +++ b/drivers/base/firmware_class.c
    @@ -1532,6 +1532,7 @@ static int fw_pm_notify(struct notifier_block *notify_block,
    switch (mode) {
    case PM_HIBERNATION_PREPARE:
    case PM_SUSPEND_PREPARE:
    + case PM_RESTORE_PREPARE:
    kill_requests_without_uevent();
    device_cache_fw_images();
    break;
    --
    1.9.0


    \
     
     \ /
      Last update: 2014-03-05 17:41    [W:3.598 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site