Messages in this thread |  | | Date | Wed, 5 Mar 2014 13:34:01 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH 05/48] percpu: Add preemption checks to __this_cpu ops |
| |
On Tue, 4 Mar 2014 21:27:14 -0600 (CST) Christoph Lameter <cl@linux.com> wrote:
> > > +notrace void __this_cpu_preempt_check(const char *op) > > > +{ > > > + char text[40]; > > > + > > > + snprintf(text, sizeof(text), "__this_cpu_%s()", op); > > > + check_preemption_disabled(text); > > > +} > > > > I'd like to see a comment here telling scared readers why this can > > never overflow text[]. > > Ok. I can also add VM_BUG_ON(strlen(op) >= sizeof(text)) ?
I misread the code - snprintf() will dtrt and we'll just end up with truncated debug text. Not worth worrying about.
|  |