lkml.org 
[lkml]   [2014]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 05/48] percpu: Add preemption checks to __this_cpu ops
On Tue, 4 Mar 2014 21:27:14 -0600 (CST) Christoph Lameter <cl@linux.com> wrote:

> > > +notrace void __this_cpu_preempt_check(const char *op)
> > > +{
> > > + char text[40];
> > > +
> > > + snprintf(text, sizeof(text), "__this_cpu_%s()", op);
> > > + check_preemption_disabled(text);
> > > +}
> >
> > I'd like to see a comment here telling scared readers why this can
> > never overflow text[].
>
> Ok. I can also add VM_BUG_ON(strlen(op) >= sizeof(text)) ?

I misread the code - snprintf() will dtrt and we'll just end up with
truncated debug text. Not worth worrying about.


\
 
 \ /
  Last update: 2014-03-09 16:02    [W:0.070 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site